Difference between revisions of "Sphinx gotchas"

From Software Heritage Wiki
Jump to: navigation, search
(reorder good/bad sections)
(Sphinx)
Line 7: Line 7:
 
All sorts of [http://www.sphinx-doc.org/en/stable/rest.html#lists-and-quote-like-blocks '''lists'''] require an empty line before the first bullet and after the last one, to be properly interpreted as list. No indentation is required for list elements w.r.t. surrounding text, and line continuations should be indented like the first character after the bullet
 
All sorts of [http://www.sphinx-doc.org/en/stable/rest.html#lists-and-quote-like-blocks '''lists'''] require an empty line before the first bullet and after the last one, to be properly interpreted as list. No indentation is required for list elements w.r.t. surrounding text, and line continuations should be indented like the first character after the bullet
  
Bad:
+
<u>Bad:</u>
 
<pre>
 
<pre>
 
this is a bad example that will not be interpreted as a list
 
this is a bad example that will not be interpreted as a list
Line 17: Line 17:
 
</pre>
 
</pre>
  
Good:
+
<u>Good:</u>
 
<pre>
 
<pre>
 
this is some text preceding the list
 
this is some text preceding the list
Line 31: Line 31:
 
</pre>
 
</pre>
  
Bad:
+
<u>Bad:</u>
 
<pre>
 
<pre>
 
- foo
 
- foo
Line 40: Line 40:
 
</pre>
 
</pre>
  
Good:
+
<u>Good:</u>
 
<pre>
 
<pre>
 
surrounding text
 
surrounding text
Line 59: Line 59:
 
Verbatim [http://www.sphinx-doc.org/en/stable/rest.html#source-code '''code blocks'''], e.g., for code examples, requires double colon at the end of a line, then an empty line, and then the code block itself, indented:
 
Verbatim [http://www.sphinx-doc.org/en/stable/rest.html#source-code '''code blocks'''], e.g., for code examples, requires double colon at the end of a line, then an empty line, and then the code block itself, indented:
  
Bad:
+
<u>Bad:</u>
 
<pre>
 
<pre>
 
This does not work as there is a single column and no empty line before code:
 
This does not work as there is a single column and no empty line before code:
Line 68: Line 68:
 
</pre>
 
</pre>
  
Good:
+
<u>Good:</u>
 
<pre>
 
<pre>
 
a nice example of python code follows::
 
a nice example of python code follows::
Line 82: Line 82:
 
'''Inline code samples''' use double backquotes, and not single ones.
 
'''Inline code samples''' use double backquotes, and not single ones.
  
Bad:
+
<u>Bad:</u>
 
<pre>
 
<pre>
 
you have to instantiate the method `def foo(bar): pass` in order to use this abstract class
 
you have to instantiate the method `def foo(bar): pass` in order to use this abstract class
 
</pre>
 
</pre>
  
Good:
+
<u>Good:</u>
 
<pre>
 
<pre>
 
you have to instantiate the method ``def foo(bar): pass`` in order to use this abstract class
 
you have to instantiate the method ``def foo(bar): pass`` in order to use this abstract class

Revision as of 13:57, 7 September 2017

Here is a list of common gotchas when formatting Python docstrings for Sphinx and the Napoleon style.

Sphinx

Lists

All sorts of lists require an empty line before the first bullet and after the last one, to be properly interpreted as list. No indentation is required for list elements w.r.t. surrounding text, and line continuations should be indented like the first character after the bullet

Bad:

this is a bad example that will not be interpreted as a list
preceding text
- foo
- bar
- baz
following text

Good:

this is some text preceding the list

- foo
- bar
- baz
- this is a rather long-ish paragraph inserted in the list
  with line continuation
- qux

this is some text following the list

Bad:

- foo
- nested lists also requires empty lines, but they are missing here
  - inner list 1
  - inner list 2
- outer list continues here

Good:

surrounding text

- foo
- nested lists also requires empty lines

  - inner list 1
  - inner list 2

- outer list continues here

surrounding text

Verbatim source code

Verbatim code blocks, e.g., for code examples, requires double colon at the end of a line, then an empty line, and then the code block itself, indented:

Bad:

This does not work as there is a single column and no empty line before code:
    def foo(bar, baz):
        qux = bar + baz

        return qux

Good:

a nice example of python code follows::

    def foo(bar, baz):
        qux = bar + baz

        return qux

here we can restart text flow

Inline code samples use double backquotes, and not single ones.

Bad:

you have to instantiate the method `def foo(bar): pass` in order to use this abstract class

Good:

you have to instantiate the method ``def foo(bar): pass`` in order to use this abstract class

Napoleon

Docstring sections

See the list of docstring sections supported by Napoleon. Everything else will not be typeset with a dedicated heading, you will have to do so explicitly using reStructuredText markup.

Args

Entries in Args section do not start with bullets, but just with argument names (as any other Napoleon section). Continuation lines should be indented.

Bad:

Args:
    - foo (int): first argument
    - bar: second argument
    - baz (bool): third argument

Good:

Args:
    foo (int): first argument
    bar: second argument, which happen to have a fairly
        long description of what it does
    baz (bool): third argument

Returns

In Returns section you need to use ":" carefully as, if present, it will be interpreted as a separator between return type and description. Also, the description of return value should not start on the same line of "Returns:", but on the subsequent one, indented.

Bad:

Returns:
    this does not work (colon will be interpreted as type/desc separator), a dict with keys:

    - foo
    - bar
<pre>

Good:
<pre>
Returns:
    this works (there is no colon) a dict with keys

    - foo
    - bar

Good:

Returns:
    dict: this works again (''first'' colon identifies the type) a dict with keys:

    - foo
    - bar

Bad:

Returns: this is not good either, you need to start a paragraph

See also