|
(Tags: Redirect target changed, Undo) |
(17 intermediate revisions by 3 users not shown) |
Line 1: |
Line 1: |
− | This page documents code review practices used for [[Software Heritage]] development.
| + | #REDIRECT [[swhdocs:devel/contributing/code-review.html#code-review]] |
− | | |
− | '''WORK IN PROGRESS page'''
| |
− | | |
− | == Guidelines ==
| |
− | | |
− | # Code reviews (CRs) are '''strongly recommended''' for any code change, but not mandatory (nor enforced at the VCS level).
| |
− | # The CR [[Code review in Phabricator|'''workflow''']] is implemented using Phabricator/Differential.
| |
− | # '''Suggest reviewer'''(s) when submitting new CR requests: either the most knowledgeable person(s) for the target code or the general [https://forge.softwareheritage.org/project/view/50/ Reviewers] group. | |
− | # '''Review anything you want''': no matter the suggested reviewer(s), feel free to review any outstanding CR.
| |
− | # '''One LGTM is enough''': feel free to approve any outstanding CR.
| |
− | # '''Review every day''': CRs should be timely as fellow developers will wait for them. To make CRs team-sustainable each developer should allocate a fixed ''minimum'' amount of time for doing CR every (work ☺) day.
| |
− | | |
− | For more detailed suggestions (and much more) on the motivational and practical aspects of code reviews see Good reads below.
| |
− | | |
− | == Good reads ==
| |
− | | |
− | Good reads on different angles of code review:
| |
− | | |
− | * '''[https://medium.com/palantir/code-review-best-practices-19e02780015f Best practices]''' (Palantir) ← comprehensive and recommended read, especially if you're short on time
| |
− | * [https://www.codeproject.com/Articles/524235/Codeplusreviewplusguidelines Review checklist] (Code Project)
| |
− | * [https://blog.fullstory.com/what-we-learned-from-google-code-reviews-arent-just-for-catching-bugs/ Motivation: team culture] (Google & FullStory)
| |
− | * [https://blog.codinghorror.com/code-reviews-just-do-it/ Motivation: code quality] (Coding Horror)
| |
− | * [http://www.processimpact.com/articles/humanizing_reviews.pdf Motivation: humanizing peer reviews] (Wiegers)
| |
− | | |
− | == See also ==
| |
− | | |
− | * [[Code review in Phabricator]]
| |
| | | |
| | | |
| [[Category:Software development]] | | [[Category:Software development]] |