Difference between revisions of "Code review"
Jump to navigation
Jump to search
(→Good Reads: organize by topic) |
(→Good Reads: highlight palantir document) |
||
| Line 9: | Line 9: | ||
Good reads on different angles of code review: | Good reads on different angles of code review: | ||
| − | * [https://medium.com/palantir/code-review-best-practices-19e02780015f Best practices] (Palantir) | + | * '''[https://medium.com/palantir/code-review-best-practices-19e02780015f Best practices]''' (Palantir) ← very comprehensive, read only this one if you're short on time |
* [https://www.codeproject.com/Articles/524235/Codeplusreviewplusguidelines Review checklist] (Code Project) | * [https://www.codeproject.com/Articles/524235/Codeplusreviewplusguidelines Review checklist] (Code Project) | ||
* [https://blog.fullstory.com/what-we-learned-from-google-code-reviews-arent-just-for-catching-bugs/ Motivation: team culture] (Google & FullStory) | * [https://blog.fullstory.com/what-we-learned-from-google-code-reviews-arent-just-for-catching-bugs/ Motivation: team culture] (Google & FullStory) | ||
Revision as of 11:51, 12 October 2018
This page documents code review practices used for Software Heritage development.
Implementation
See Code review in Phabricator.
Good Reads
Good reads on different angles of code review:
- Best practices (Palantir) ← very comprehensive, read only this one if you're short on time
- Review checklist (Code Project)
- Motivation: team culture (Google & FullStory)
- Motivation: code quality (Coding Horror)
- Motivation: humanizing peer reviews (Wiegers)